On Fri, Apr 24, 2009 at 04:28:46PM +0200, Guido Trotter wrote:
>
> Don't show all instances info by default, but require --all to be passed
> for this time consuming operation.
> ---
> scripts/gnt-instance | 15 ++++++++++++++-
> 1 files changed, 14 insertions(+), 1 deletions(-)
>
> @@ -1360,7 +1369,11 @@ commands = {
> make_option("-s", "--static", dest="static",
> action="store_true", default=False,
> help="Only show configuration data, not runtime
> data"),
> - ], "[-s] [<instance>...]",
> + make_option("--all", dest="show_all",
> + default=False, action="store_true",
> + help="Show info on all instances on the cluster."
> + " This can take a long time to run, use wisely."),
> + ], "[-s] [<instance>...|--all]",
If should be not [<instance>...|--all], but {}, and preferablly list --all
first:
[-s] {--all | <instance>...}
After that LGTM.
iustin
