On Wed, Aug 5, 2009 at 2:17 PM, Iustin Pop<[email protected]> wrote:
> Uh, simplification maybe?: > for node_name in node_names: > ni = self._UnlockedGetNodeInfo(node_name) > node_info.append(ni) > node_pri_ips.append(ni.primary_ip) > node_snd_ips.append(ni.secondary_ip) > > And then you don't need two new functions. Mh yeah, I've realized it now (I left the functions at last when I wrote the changes, it was an unknown part ;) ). > Plus, you're half way into Guido's patch from yesterday about optimising > this, so why not go 100% (and change off_data, on_data, mc_data to be > the same). Ok! I'm resending the patch without the functions and the optimization. Will send another patch for optimization so we keep them logically separated in two commits. Thank you Luca
