2009/8/11 Guido Trotter <ultrot...@google.com>:
> --- a/lib/confd/querylib.py
> +++ b/lib/confd/querylib.py
> @@ -55,6 +55,11 @@ class ConfdQuery(object):
>     answer = 'not implemented'
>     return status, answer
>
> +  UnknownEntryError = (constants.CONFD_REPL_STATUS_ERROR,
> +                       constants.CONFD_ERROR_UNKNOWN_ENTRY)
> +  InternalError = (constants.CONFD_REPL_STATUS_ERROR,
> +                   constants.CONFD_ERROR_INTERNAL)

They're not classes or methods, but rather constants and should be
uppercase. Can you also prefix the names with CONFD_? “InternalError”
looks like something built into Python (it's not, but it can be
confusing).

Regards,
Michael

Reply via email to