On Fri, Nov 27, 2009 at 3:30 PM, Iustin Pop <[email protected]> wrote:
> The DRBD driver can ignore dead disks but not dead meta devices (for
> which it refuses to configure the minor). To handle this case, we check
> that the meta device is readable and if not we ignore it (the same as
> when backend._RecursiveAssembleBD didn't find it).
>
> A needed change is the move of some checks and initialisers before this
> test (which is before the super().__init__ call), but that should be
> fine.
>
> [To be removed from commit msg: Alternative implementation would be to
> not read from the device but checks that it returns LDS_OKAY on
> GetSyncStatus.ldisk_status, but that doesn't necessarily tell if we can
> read from it]

LGTM

Thanks,

Guido

Reply via email to