On Tue, Jan 19, 2010 at 02:26:56PM +0100, Michael Hanselmann wrote: > 2010/1/19 Iustin Pop <ius...@google.com>: > > On Mon, Jan 18, 2010 at 04:54:20PM +0100, Michael Hanselmann wrote: > >> Also fix a typo in http/__init__.py and add unittests > >> for the LUXI parsing and formatting functions. > > > > I didn't look yet at the whole patch, but why adding "Message" to all > > functions (and "Luxi" too, this is the luxi module)? > > > > ParseRequest, ParseResponse, FormatRequest, FormatResponse. > > It has been a while since I wrote this code. I agree with dropping the > “Luxi”. Proabably I added the “Message” since Luxi is a message-based > protocol as it sends a request and then waits for the response. Are > you fine with just removing “Luxi”?
Not really, as I don't see why ParseRequestMessage is better than ParseRequest, it seems only extra text noise :) (I'll look at the rest of the patch too) iustin
