On Tue, Jan 19, 2010 at 05:07:03PM +0100, Michael Hanselmann wrote: > This patch fixes a quoting issue in daemon-util: > > $ EXTRA_MASTERD_ARGS=--no-voting /etc/init.d/ganeti restart > […] > * ganeti-masterd... > /…/ganeti/daemon-util: line 65: local: `--no-voting': not a valid identifier > > The reason was that the generated variables were not quoted properly and > the troublesome line expanded to > “local args=$MASTERD_ARGS $EXTRA_MASTERD_ARGS” instead of the correct > “local args="$MASTERD_ARGS $EXTRA_MASTERD_ARGS"”.
eval is evil by nature :) LGTM!
