2010/5/18 Iustin Pop <[email protected]>:
> On Tue, May 18, 2010 at 02:36:04PM +0200, Michael Hanselmann wrote:
>> --- a/lib/constants.py
>> +++ b/lib/constants.py
>> @@ -333,6 +333,12 @@ LOCKS_APPEND = 'append'
>> INSTANCE_CREATE = "create"
>> INSTANCE_IMPORT = "import"
>>
>> +# Remote import/export handshake message
>> +RIE_HANDSHAKE = "Hi, I'm Ganeti"
>
> I wonder if this shouldn't be tied to the Ganeti version (or RIE/IED
> protocol version), so that the handshake fails between incompatible
> versions.
You're right, a RIE protocol version should be included in the
handshake. It also serves the purpose of checking whether the cluster
domain secret matches early in the import phase. I'll update the
patches accordingly.
>> --- a/lib/opcodes.py
>> +++ b/lib/opcodes.py
>> +class OpPrepareExport(OpCode):
>> + """Prepares an instance export.
>> +
>> + �...@ivar instance_name: Instance name
>> + �...@ivar mode: Export mode (one of L{constants.EXPORT_MODES})
>
> Does this work correctly? I would expect ganeti.contants.EXPORT_MODES to
> be required.
I'm not sure whether I understand. If you mean the epydoc link, then
yes, it works correctly.
Thanks,
Michael
