2010/5/26 Guido Trotter <[email protected]>: > --- a/daemons/ganeti-masterd > +++ b/daemons/ganeti-masterd > class ClientRequestWorker(workerpool.BaseWorker): > # pylint: disable-msg=W0221 > - def RunTask(self, server, request, client_address): > + def RunTask(self, server, message, client): > """Process the request. > > """ > […] > + > + # FIXME: send data via push :) > + client.connected_socket.sendall(luxi.FormatResponse(success, result) > + + constants.LUXI_EOM)
Apart from the fact that the operator goes to the previous line: If the master thread still tries to read from the socket while the request is handled (I guess it does), and the client sends more requests, the replies could be intermixed as different threads will write their replies whenever they're ready. LUXI is a synchronous protocol, hence ordering is important. Is this already taken care of? Michael
