Re: [PATCH master 2/2] Add KVM chroot feature

[Balazs Lecz]

On Thu, May 27, 2010 at 18:42, Iustin Pop <ius...@google.com> wrote:

> On Wed, May 26, 2010 at 04:53:02PM +0100, Balazs Lecz wrote:
> > +    return utils.PathJoin(cls._CHROOT_DIR, "%s" % instance_name)
>
> "%s" % a -> a?
>

Ah, but of course...


>
> > +
> > +  @classmethod
> > +  def _InstanceChrootQuarantineDir(cls, instance_name):
> > +    """Returns the name of the KVM chroot quarantine dir of the instance
> > +
> > +    """
> > +    return utils.PathJoin(cls._CHROOT_QUARANTINE_DIR, "%s_%s"
> > +                          % (instance_name,
> utils.TimestampForFilename()))
>
> "%s_%s" -> , instance_name, utils.Timestamp… (i.e. two-levels
> structure)?
>
>
 Sure, I'll do that.

/leczb