Am 2. Juni 2010 16:06 schrieb Tom Limoncelli <t...@google.com>:
> Update ganeti-watcher so that it tests the master's RAPI port with a
> simple test (in this case GetVersion). If it fails, make one attempt
> at restarting ganeti-rapi and retest.

LGTM

I'll push with small changes:

> --- a/daemons/ganeti-watcher
> +++ b/daemons/ganeti-watcher
> @@ -48,6 +48,9 @@ from ganeti import ssconf
>  from ganeti import bdev
>  from ganeti import hypervisor
>  from ganeti.confd import client as confd_client
> +from ganeti import rapi

This should be above the confd import.

> +import ganeti.rapi.client # pylint: disable-msg=W0611
> […]
> +def IsRapiResponding(hostname):
> +  """Connects to RAPI port and does a simple test.
> +
> +Connects to RAPI port of hostname and does a simple test. At
> +this time, the test is GetVersion.

Missing indentation.

> […]

> --- a/lib/utils.py
> +++ b/lib/utils.py
> +def StopDaemon(name):

I hope this will not be confusing for people looking at “StartDaemon”
(which is used to start the import/export daemon).

Michael

Reply via email to