On Wed, Jun 23, 2010 at 12:21:13PM +0200, Guido Trotter wrote: > On Wed, Jun 23, 2010 at 12:00 PM, Iustin Pop <[email protected]> wrote: > > On Wed, Jun 23, 2010 at 11:58:20AM +0200, Iustin Pop wrote: > >> On Tue, Jun 22, 2010 at 06:30:06PM +0200, Iustin Pop wrote: > >> > On Tue, Jun 22, 2010 at 04:10:28PM +0200, Guido Trotter wrote: > >> > > On Wed, Jun 16, 2010 at 5:21 AM, Iustin Pop <[email protected]> wrote: > >> > > > + for key in sorted(instance["os_actual"]): > >> > > > + if key in instance["os_instance"]: > >> > > > + val = instance["os_instance"][key] > >> > > > + else: > >> > > > + val = "default (%s)" % instance["os_actual"][key] > >> > > > + buf.write(" - %s: %s\n" % (key, val)) > >> > > > >> > > This code is quite a lot similar (almost the same) to the one for > >> > > printing hv params. > >> > > How about we collapse it (and perhaps we could use the same for > >> > > beparams too, we'd lose capitalization, but keep the output the same > >> > > as the input, and avoid changes if we ever add a be param). > >> > > >> > Yeah, I was thinking something like that. Let me see what I can do. > >> > >> OK, +the list this time :) > >> > >> Interdiff: > > > > Wrong interdiff, buf was missing. Another try: > > > > LGTM (should we convert be parameter printing to the same?)
Maybe later :) iustin
