On Wed, Jun 23, 2010 at 01:32:22PM +0200, Guido Trotter wrote: > On Wed, Jun 23, 2010 at 1:03 PM, Iustin Pop <[email protected]> wrote: > > On Tue, Jun 22, 2010 at 04:37:01PM +0200, Guido Trotter wrote: > >> On Wed, Jun 16, 2010 at 5:21 AM, Iustin Pop <[email protected]> wrote: > >> > This patch exports all the way from backend a new field ‘api_version’ > >> > which holds the list of support API versions, and exposes the (already > >> > computed) ‘parameters’ field. > >> > > >> > The patch also reworks (again) the field calculation in its Exec() > >> > method. All callers of LUDiagnoseOS pass in the 'valid' and 'variants' > >> > parameters, thus having the special casing of whether to compute or not > >> > the validity seems overkill. We move to a model where we always compute > >> > these across-nodes arguments, in order to simplify the code, and we also > >> > change the parameters set to be intersection of all node's values (which > >> > means a change in description will drop the parameter from the list of > >> > parameters). > >> > >> Silently?? I see trouble here. > > > > Would you propose to consider the OS invalid then? I think that's worse… > > > > Basically, the differing parameters will be considered invalid, and you > > can examine in diagnose OS the status of the OS (why those are invalid). > > > > But will it tell you? It'd be nice if gnt-os info and gnt-os diagnose > would tell you the list > of invalid variants and parameters, perhaps?
I thought they do? By showing the per-node status? If not, yes, we should do that. > >> > Additionally, we update scripts/gnt-os, which was broken for multi-dir > >> > OSes since the introduction of variants… > >> > >> Multi-dir oses? > > > > Not multi-dir, but for the OSes which have copies in multiple dirs (in > > OS_SEARCH_PATH). > > > > Ah, ok, I didn't realize it was broken. What happened? Since you asked :) You added the variants listing to the 'first_os', but not to the additional OSes. So it was: for hpath, hstatus, hmsg in node_info: instead of: for hpath, hstatus, hmsg, variants in node_info: iustin
