On Wed, Jun 30, 2010 at 05:15:18PM +0100, Luca Bigliardi wrote:
> Signed-off-by: Luca Bigliardi <[email protected]>
> ---
>  lib/config.py                  |   16 ++++++++++++++++
>  lib/objects.py                 |    1 +
>  test/ganeti.config_unittest.py |    1 +
>  3 files changed, 18 insertions(+), 0 deletions(-)

I don't like the fact this leaves the new variable undefined (even if
two patches later you define it), since it makes this patch (by itself)
not good. Could you maybe initialize it to None, at least, in
UpgradeConfig?

iustin

Reply via email to