On Thu, Jul 01, 2010 at 01:37:32PM +0200, Michael Hanselmann wrote: > Am 1. Juli 2010 13:19 schrieb Iustin Pop <[email protected]>: > > On Thu, Jul 01, 2010 at 01:12:11PM +0200, Michael Hanselmann wrote: > >> In short: it needs to called in all programs. In multi-threaded > >> programs before starting any thread. Not calling global_init causes > >> libcurl to do so automatically when doing the first transfer, which > >> might be fine in single-threaded programs, but not when more than one > >> thread is running. > > […] > > > > Thanks. Can you just change in the commit msg "when only one thread is > > running" to "before starting any threads"? > > I could, but it'd also be valid to start it after stopping other > threads again (at least in C, not sure about Python). Should I change > it anyway?
Then just say: call it always :), or don't reword it. To me, the current wording is very confusing. > >> >> + curl.setopt(pycurl.MAXREDIRS, 5) > > > > Yes, but still & AFAIK, redirects can be evil (e.g. redirects and curl > > re-sending authentication etc.). > > Disabled redirects after offline discussion. If used at some point > we'll enable it again. thanks :) iustin
