On Fri, Jul 02, 2010 at 02:46:53PM +0100, Luca Bigliardi wrote:
> On Fri, Jul 2, 2010 at 2:22 PM, Guido Trotter <[email protected]> wrote:
>
> > This might be a bit problematic.
> > If we set the drbd helper to None then we'll trigger the upgrade code
> > from then on every time we start ganeti.
> > And if a drbd instance has been created in the meantime, this will
> > reset the parameter to constants.DEFAULT_DRBD_HELPER.
> > Not sure if this is buggy, just not nice, or ok.
>
> Mh yeah, it's not foolproof (a fool can do --disable-drbd-storage and then
> create a drbd instance).
>
> > Possible solutions:
> > - another explicit "drbd enabled or not" parameter
>
> I'd prefer to not add another parameter
>
> > - if this parameter is set to none disallow creating drbd instances.
> > this will trigger the code but at least no flip the parameter under
> > the user's nose.
>
> Which kinda stretch the drbd usermode helper check concept..
>
> > - any more ideas?
>
> Don't upgrade automatically but let the user modify the cluster
> settings explicitely?
The actual problem here is that you're using None, which is a value not
allowed for parameters in our configuration objects.
Just add a different value ('disabled'), that is not an absolute path
name.
iustin
