On Tue, Jul 6, 2010 at 7:08 PM, Iustin Pop <[email protected]> wrote:
> + if options.reboot_types is None:
> + options.reboot_types = constants.REBOOT_TYPES
> + else:
> + options.reboot_types = options.reboot_types.split(",")
> + rt_diff = set(options.reboot_types).difference(constants.REBOOT_TYPES)
> + if rt_diff:
> + Err("Invalid reboot types specified: %s" % utils.CommaJoin(rt_diff))
> +
Optionally you can also warn the user if do_reboot is None and
reboot_types is not None:
to me it seems do_reboot will silently override reboot_types.
Apart from this LGTM.
Thank you,
Luca
