On Tue, Jul 06, 2010 at 02:59:07PM +0300, Apollon Oikonomopoulos wrote:
> Hi,
>
> I implemented selective block device handling, revised patch follows.
Looks good, however here:
> +def GetBlockdevList(devices):
> + """Compute the list of block devices and their size
> +
> + @rtype: dict
> + @return:
> + dictionary of all block devices under /dev/disk (key). The value is their
> + size in MiB.
> +
> + {'/dev/disk/by-uuid/123456-12321231-312312-312': 124}
> +
> + """
You're not documenting the 'devices' parameter. Do I understand
correctly that it needs to be either empty or contain a list of absolute
path names?
If so, then we should document it, and restrict the path names to be under /dev…
regards,
iustin
