On Thu, Dec 16, 2010 at 1:34 PM, Guido Trotter <[email protected]> wrote: > On Mon, Dec 13, 2010 at 3:21 PM, Apollon Oikonomopoulos > <[email protected]> wrote: >> Passing tap devices to KVM as file descriptors requires that the respective >> file decriptors remain open during utils.RunCmd execution. To this direction, >> we add a “noclose_fds” keyword argument to utils.RunCmd, accepting a list of >> file descriptors to keep open. The actual fd handling is implemented in >> _RunCmdPipe and _RunCmdFile using subprocess.Popen's “preexec_fn”[1], >> since subprocess.Popen provides no other way to selectively handle fds. >> > > Good, but I think the RunCmd changes should be in a separate patch > than the kvm changes that use them?
Ok, of course it is, sorry, was confused by the description mentioning KVM ! :) Sorry! Guido
