Am 8. März 2011 16:23 schrieb Rene Nussbaumer <[email protected]>:
> On Tue, Mar 8, 2011 at 4:19 PM, Michael Hanselmann <[email protected]> wrote:
>> Am 8. März 2011 16:06 schrieb René Nussbaumer <[email protected]>:
>>> --- a/lib/cmdlib.py
>>> @@ -3366,6 +3368,10 @@ class LUOobCommand(NoHooksLU):
>>>
>>>           node_entry.append((constants.RS_NORMAL, result.payload))
>>>
>>> +          if (self.op.command == constants.OOB_POWER_ON and
>>> +              node != self.nodes[-1]):
>>> +            time.sleep(self.op.power_delay)
>>
>> If there's code ensuring that all names in self.nodes are unique,
>> LGTM. Otherwise you should use enumerate() and check the index against
>> “len(self.nodes) - 1” (it's cleaner anyway).
>
> Good point:

LGTM

Reply via email to