Am 14. März 2011 16:54 schrieb Rene Nussbaumer <[email protected]>: > On Fri, Mar 11, 2011 at 3:51 PM, Michael Hanselmann <[email protected]> wrote: >> - query = "&".join("tag=%s" % i for i in tags) >> + queryargs = "&".join("tag=%s" % i for i in tags) > > LGTM, except for this part. I find it rather confusing to see > queryargs (where I expect a list) than query, which is the name > referred and documented everywhere else (and also in the RFC).
- ganeti.rapi.baserlib already uses queryargs as a name - The newly imported ganeti.query conflicts with a variable named “query” Please reconsider. :-) Michael
