On Mon, Mar 21, 2011 at 04:51:50PM +0200, Apollon Oikonomopoulos wrote: > On 12:15 Thu 10 Mar , Michael Hanselmann wrote: > > Am 10. März 2011 11:57 schrieb Iustin Pop <[email protected]>: > > > Actually this fails in the same way for migration. Interdiff: > > > > LGTM > > Hi, > > this actually broke some stuff. Following patch should fix these. > > Thanks, > Apollon > -- > > Commit faaabe3c fixed failover behaviour for DTS_INT_MIRROR instances, however > it broke migration for DTS_EXT_MIRROR instances, by moving iallocator and node > checks from LUInstanceMigrate to TLMigrateInstance. This has the side-effect > that the LU called the TL with None for both, node and iallocator when the > default iallocator was being used. > > This patch maintains the iallocator checks in TLMigrateInstance and fixes the > LU-TL integration.
Thanks. As discusses on IRC, this doesn't apply cleanly on master (seems to have wrong context in TLMigrateInstance), so I'll wait for an updated version. Thanks for catching this! iustin
