On Thu, Mar 24, 2011 at 09:41:59PM +0000, Adeodato Simo wrote: > This commits breaks down the "Input message" section of iallocator.rst into > two separate subsections: one detailing keys that are required in all > operation types; a second one detailing the "request" element, which is > different for each type of request. > > Some other minor improvements are included as well: > > - update input example to version 2, and add the "nodegroups" and > "enabled_hypervisors" top-level elements, and the "group" and > "hypervisor" attributes for nodes and allocation request, respectively. > > - sort keys in the example dictionaries according to the order in earlier > sections, for easy comparison of documentation with its examples. > > Signed-off-by: Adeodato Simo <[email protected]> > --- > > Hi, > > This is the change I mentioned I'd be sending. I *think* it makes the > document more readable, and it makes it a bit less messy to add new > operation types. Please let me know what you think.
Agreed. LGTM, with one tiny request: please keep the mention of the 'request' field in the common section, as all messages will have this field (just don't document its contents). thanks, iustin
