On Mon, Mar 28, 2011 at 11:34:20AM +0200, René Nussbaumer wrote: > This fixes a issue, where an stopped instances is reported as ERROR > in cluster verify if it lives on a offline node. As the instances is > down this shouldn't happen. > --- > lib/cmdlib.py | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/lib/cmdlib.py b/lib/cmdlib.py > index a35a54b..a40c539 100644 > --- a/lib/cmdlib.py > +++ b/lib/cmdlib.py > @@ -2360,7 +2360,8 @@ class LUClusterVerify(LogicalUnit): > self.ENODERPC, pnode, "instance %s, connection to" > " primary node failed", instance) > > - _ErrorIf(pnode_img.offline, self.EINSTANCEBADNODE, instance, > + _ErrorIf(inst_config.admin_up and pnode_img.offline, > + self.EINSTANCEBADNODE, instance, > "instance lives on offline node %s", inst_config.primary_node)
Could you fix the error message too? If we only warn for admin_up instances, then it should be something like "instance is marked as running and lives on offline node %s". thanks, iustin
