On Fri, Mar 25, 2011 at 09:07:23PM +0000, Adeodato Simo wrote: > > Signed-off-by: Adeodato Simo <[email protected]> > --- > > Hi, > > this is a cleaned-up version of the discussion we had on inter-group > instance moves. > > The design for shared storage went in shortly after our discussion; I've > read that design document now, to see if it altered our proposal at all. > I could only see that the IAllocator will have to consider mobility > domains, so I've added a couple mentions to that. > > While writing this document, for a moment I *thought* that the "mode of > operation" attribute of the IAllocator call was redundant: by just > accepting a list of node groups, it seemed "Any" could be expressed by > listing all groups, "Stay in group" by listing only the current group, > and "Change group" by listing the desired target groups (e.g. X and Y, > or all but the current group). > > Later I realized, the listed instances need not belong all to the same > group, so the design below is richer than a pure list of node groups. > > If you think this needs explicit mentioning in the document, please let > me know.
LGTM, thanks. I will say though that this is not enough, and that it will need detailed value documentation in iallocator.rst itself. That can be done in a later patch. thanks, iustin
