On Fri, May 13, 2011 at 05:35:46PM +0200, Michael Hanselmann wrote:
> ---
> lib/cmdlib.py | 12 ++++++++++++
> lib/opcodes.py | 5 +++++
> 2 files changed, 17 insertions(+), 0 deletions(-)
I think LGTM, see one note below:
> diff --git a/lib/opcodes.py b/lib/opcodes.py
> index 698fb45..0cbd5cd 100644
> --- a/lib/opcodes.py
> +++ b/lib/opcodes.py
> @@ -1430,6 +1430,11 @@ class OpTestAllocator(OpCode):
> ("disk_template", None, ht.TMaybeString, None),
> ("evac_nodes", None, ht.TOr(ht.TNone, ht.TListOf(ht.TNonEmptyString)),
> None),
> + ("instances", None, ht.TOr(ht.TNone, ht.TListOf(ht.TNonEmptyString)),
> + None),
> + ("reloc_mode", None, ht.TMaybeString, None),
Shouldn't reloc mode be ht.TElemOf(constants.…)?
> + ("target_groups", None, ht.TOr(ht.TNone, ht.TListOf(ht.TNonEmptyString)),
> + None),
thanks,
iustin
