On 16:36 Mon 06 Jun , Michael Hanselmann wrote: > Am 6. Juni 2011 14:37 schrieb Apollon Oikonomopoulos <[email protected]>: > > --- a/lib/hypervisor/hv_xen.py > > +++ b/lib/hypervisor/hv_xen.py > > +_VALID_NIC_MODES = [constants.NIC_MODE_ROUTED, constants.NIC_MODE_BRIDGED] > > Please use constants.NIC_VALID_MODES. > > Michael
constants.NIC_VALID_MODES includes all valid NIC modes, including "manual" introduced by this patchset. We want to explicitly allow only bridged and routed instances, that Xen knows how to handle. Apollon
