On Fri, Jun 24, 2011 at 03:10:35PM +0200, Rene Nussbaumer wrote: > On Fri, Jun 24, 2011 at 1:55 PM, Stephen Shirley <[email protected]> wrote: > > Creates the instance, but pauses execution before booting. This combined > > with 'gnt-instance console' unpausing instances means that the entire > > boot process can be viewed and monitored. > > > > Signed-off-by: Stephen Shirley <[email protected]> > > --- > > lib/backend.py | 6 ++++-- > > lib/cli.py | 4 ++++ > > lib/client/gnt_instance.py | 5 +++-- > > lib/cmdlib.py | 15 ++++++++++----- > > lib/hypervisor/hv_base.py | 2 +- > > lib/hypervisor/hv_chroot.py | 2 +- > > lib/hypervisor/hv_fake.py | 2 +- > > lib/hypervisor/hv_kvm.py | 8 +++++--- > > lib/hypervisor/hv_lxc.py | 2 +- > > lib/hypervisor/hv_xen.py | 8 ++++++-- > > lib/opcodes.py | 5 +++++ > > lib/rpc.py | 4 ++-- > > lib/server/noded.py | 3 ++- > > 13 files changed, 45 insertions(+), 21 deletions(-) > > > > diff --git a/lib/cli.py b/lib/cli.py > > index 1db36ec..a87838e 100644 > > --- a/lib/cli.py > > +++ b/lib/cli.py > > @@ -140,6 +140,7 @@ __all__ = [ > > "OS_OPT", > > "OS_SIZE_OPT", > > "OOB_TIMEOUT_OPT", > > + "PAUSE_OPT", > > "POWER_DELAY_OPT", > > "PREALLOC_WIPE_DISKS_OPT", > > "PRIMARY_IP_VERSION_OPT", > > @@ -1210,6 +1211,9 @@ NO_REMEMBER_OPT = cli_option("--no-remember", > > help="Perform but do not record the change" > > " in the configuration") > > > > +PAUSE_OPT = cli_option("--pause", action="store_true", default=False, > > + help="Pause instance at startup") > > + > > Personally, I would move this code directly into gnt_instance.py or do > you intended to use it somewhere else as well?
René, the intention is to have all CLI options defined in a single place. The ones that weren't moved were special ones, but in general I much appreciate having them in only one place. thanks, iustin
