Sorry, I hadn't found the style guide. I will read it and do a better job with it next time.
Thanks for the update, Ben On Tue, Jul 12, 2011 at 5:59 AM, Iustin Pop <[email protected]> wrote: > On Fri, Jul 01, 2011 at 04:06:10PM -0400, Ben Lipton wrote: > > Added a script that generates an initrd suitable for running an OS > > entirely from RAM, to be used as a target for physical-to-virtual > > transfers. > > LGTM this time, but I had to edit the patch heavily. > > 1. You didn't add full copyright headers. Please do so next time. > > 2. You didn't use epydoc docstrings, but "Args: , Returns: ", etc. > Please use eypdoc docstrings in the future. > > 3. You used ' for strings, whereas our style guide specifies " for any > new code. > > 4. You used __author__, which we don't use - the authorship information > is in the git logs. > > 5. Wrapping of docstrings was again bad. > > Please make sure to read http://code.google.com/p/ganeti/wiki/StyleGuide > and follow it in the future. > > Now about the code, I saw that you use the script both as a module and > as a script. I'd recommend splitting the code into a proper module, and > the script just imports that module. > > Also, you added 'mox' as a dependency—please note this in the README. > > thanks, > iustin >
