On Wed, Jul 13, 2011 at 06:06:35PM +0200, Iustin Pop wrote:
> [+list]
> On Wed, Jul 13, 2011 at 04:20:28PM +0100, Guido Trotter wrote:
> > On Fri, Jul 08, 2011 at 04:21:48PM +0200, Iustin Pop wrote:
> > 
> > Hi,
> > 
> > >  nodeEvacInstance :: Node.List         -- ^ The node list (cluster-wide)
> > >                   -> Instance.List     -- ^ Instance list (cluster-wide)
> > >                   -> EvacMode          -- ^ The evacuation mode
> > > -                 -> IntSet.IntSet     -- ^ List of excluded node indices
> > > -                 -> [(Gdx, [Ndx])]    -- ^ Group-node indices association
> > >                   -> Instance.Instance -- ^ The instance to be evacuated
> > > +                 -> [Ndx]             -- ^ The list of available nodes
> > > +                                      -- for allocation
> > >                   -> Result (Node.List, Instance.List, [OpCodes.OpCode])
> > 
> > You introduced nodeEvacInstance two patches ago. Would it make sense to move
> > this patch before, and introduce it directly in the "corrected" way?
> 
> If our goal is 'best' history, yes. Rebasing is sometimes hard and I see
> no real gain in doing it, honestly.

I took another look and what I can do is simply squash this on top of
the patch you mention. Is that better?

thanks!
iustin

Reply via email to