Ah, very true. I meant for the quotes to actually appear in the printed string, but I forgot to quote the whole message so they're just useless. Updated patch coming.
On Thu, Jul 21, 2011 at 1:08 AM, Michael Hanselmann <[email protected]>wrote: > Am 20. Juli 2011 20:33 schrieb Ben Lipton <[email protected]>: > > --- a/doc/Makefile.am > > +++ b/doc/Makefile.am > > %.html: %.rst > > - @test -n "$(RST2HTML)" || \ > > - { echo 'rst2html' not found, docs will not be built; exit 1; > } > > - $(RST2HTML) $< > $@ > > + @if test -n "$(RST2HTML)"; then\ > > + $(RST2HTML) $< > $@;\ > > + else\ > > + echo 'rst2html' not found, docs will not be built;\ > > Just quoting “rst2html” is pointless here. Either quote the full > message or nothing. > > > + fi > > Rest LGTM. >
