On Fri, Jul 22, 2011 at 10:31:28AM -0400, Benjamin Lipton wrote: > On Fri, Jul 22, 2011 at 7:21 AM, Iustin Pop <[email protected]> wrote: > > > On Wed, Jul 20, 2011 at 02:33:42PM -0400, Ben Lipton wrote: > > > p2v_transfer.py is run from the transfer OS to connect to the instance > > > and perform the transfer. It takes three arguments: > > > * Device that stores the root filesystem of the source OS > > > * Name or address of instance to connect to > > > * Path of a private key matching the public key installed on the > > > instance. > > > > > > For the time being, the administrator needs to generate the keys and > > > provide the private key to the user manually. > > > > LGTM and will push, with some comments. You can either address them or > > add TODOs/README notes about them: > > > > Thanks, I will write myself some TODOs, as I can't see any deep reasons to > require xen or python > 2.5. In addition to your comments below, I'm also > putting in a note to update the partitioning so that the swap size depends > on the swap size on the source machine or the space available on the > instance. Right now it's a constant (and totally arbitrary) value set in the > main function, but I'm not planning to leave it that way.
Thanks, much appreciated. iustin
