On Thu, Aug 04, 2011 at 10:11:06AM -0400, Benjamin Lipton wrote: > On Thu, Aug 4, 2011 at 10:08 AM, Iustin Pop <[email protected]> wrote: > > > On Thu, Aug 04, 2011 at 03:05:48PM +0100, Andrea Spadaccini wrote: > > > Hi Iustin, > > > > > > > + if not re.match("[-a-zA-Z0-9.]+$", args[1]): > > > > > > > > > > > > > > > > Here you could use ganeti.netutils.Hostname._VALID_NAME_RE, that also > > > > checks > > > > > for the length of the hostname. > > > > > > > > Except that this isn't in the ganeti codebase… :) > > > > > > > > > > Erh... right... well, he can kinda *use* it by copy and paste, right? :) > > > > Hah, right :) > > > > Shall I?
I think it's fine as it is. If you want, you can try to copy an improved one, but it's up to you. iustin
