Hi Guido, > + spice_ip_version = hvp[constants.HV_KVM_SPICE_IP_VERSION] > > + if spice_ip_version == > constants.SPICE_USE_CLUSTER_DEFAULT_IP_VERSION: > > + cluster_family = ssconf.SimpleStore().GetPrimaryIPFamily() > > + spice_ip_version = > netutils.IpAddressFamilyToVersion(cluster_family) > > What if it's an interface that has only a v6 or only a v4 address? We > don't want to use the cluster default in that case, only if we're > undecided.
i think that the user should specify the IP version, even if the chosen interface has only an IPvX version. I mean, if cluster default IP version is Y andthe user specifies an interface that has only IPvX IPs, we should throw an error. Or should we try to adapt and just raise a warning? > Can we just force spice_ip_version to 0 and use the right one when an > ip is specified? The code is changed and I am going to resend it today, but basically it works like that: - if there is a version mismatch between the IP version and an IP (both passed by the user), raise an error; - if the user specifies an IP version (say X) and an interface with no IPvX IPs, raise an error - the same goes if the user does not specify an IP version, the cluster default IP version is X and the user specifies an interface without IPvX IPs - KVM version must be > 0.14 Is there anything that should be changed? > > > + spice_pwd_file = hvp[constants.HV_KVM_SPICE_PASSWORD_FILE] > > + if spice_pwd_file: > > + try: > > + spice_pwd = utils.ReadOneLineFile(spice_pwd_file, strict=True) > > + spice_arg = "%s,password=%s" % (spice_arg, spice_pwd) > > There's no other way to pass the password besides the command line? :( > (even after starting the instance via the monitor would do) I will address the password in a later patch. :) Thanks, Andrea
