On Tue, Aug 09, 2011 at 10:41:44AM -0400, Ben Lipton wrote: > Break out reading of source OS /etc/fstab into its own function, so we > only have to do it once. Using the results we can more reliably find the > amount of swap on the source machine. Also, we can mount and unmount all > of the disks that would normally be part of the source filesystem, > instead of being stuck with only the / partition. > > Signed-off-by: Ben Lipton <[email protected]> > --- > p2v-transfer/p2v_transfer.py | 150 > ++++++++++++++++++++++++-------- > p2v-transfer/test/p2v_transfer_test.py | 85 +++++++++--------- > 2 files changed, 154 insertions(+), 81 deletions(-)
LGTM, one comment: > + for dev, mount_point in fs_devs.iteritems(): I've changed this to just items(): for the size of fstab, it shouldn't matter. (Yes, I know you remove it in a later patch) thanks, iustin
