Hi Michael, thanks for the suggestions. I will apply all of them and resend the patch series.
Here are some comments: > +VALID_IP_VERSIONS = frozenset([IP4_VERSION, IP6_VERSION]) > > Please reformat according to > <http://code.google.com/p/ganeti/wiki/StyleGuide#Formatting_sequences>: > > VALID_IP_VERSIONS = frozenset([ > IP4_VERSION, > IP6_VERSION, > ]) > I checked that, and seems that for short sequences it is ok to put them in one line. [cut] You should also add verification using inet_pton, i.e. only add the > address if it's valid. Right, I completely forgot that! Thanks, Andrea
