Hi Michael,
>> + # pylint: disable=E1101
>> assert not job.writable, "Got writable job"
>
> Please put this disable on the same line so that it's a per-line
> disable. Rest LGTM.
Ok, thanks.
Andrea
Interdiff:
diff --git a/lib/jqueue.py b/lib/jqueue.py
index 2343ee8..3cf3b42 100644
--- a/lib/jqueue.py
+++ b/lib/jqueue.py
@@ -2187,8 +2187,7 @@ class JobQueue(object):
# Try to load from disk
job = self.SafeLoadJobFromDisk(job_id, True, writable=False)
- # pylint: disable=E1101
- assert not job.writable, "Got writable job"
+ assert not job.writable, "Got writable job" # pylint: disable=E1101
if job:
return job.CalcStatus()