Hi Michael, > Can we have slightly shorter constant names? s/IMAGE/IMG/, > s/COMPRESSION/COMPR/?
Will do. >> + def _GenerateKVMRuntime(self, instance, block_devices, #pylint: >> disable=R0914 > > You can put this one just into the function body. Will do, thanks. >> + spice_arg = "%s,image-compression=%s" % (spice_arg, img_lossless) > > Why aren't you using StringIO to generate such a long string? Not for > performance reasons, but fewer repetitions of the variable name. Good point, I will do this change both for SPICE and VNC. I'll send a separate patch to leave this just for compression/streaming. Thanks, Andrea
