Re: [PATCH master 02/18] Fix parameters to RPC "blockdev_rename"

[Michael Hanselmann]

Am 24. Oktober 2011 18:55 schrieb Iustin Pop <ius...@google.com>:
> On Mon, Oct 24, 2011 at 06:46:37PM +0200, Michael Hanselmann wrote:
>> index c67da12..2bb8161 100644
>> --- a/lib/server/noded.py
>> +++ b/lib/server/noded.py
>> -    devlist = [(objects.Disk.FromDict(ds), uid) for ds, uid in params]
>> +    devlist = [(objects.Disk.FromDict(ds), uid) for ds, uid in (params, )]
>
> Sorry, I can't read this properly, could you explain more?

It doesn't do the right thing. Interdiff:

--- a/lib/server/noded.py
+++ b/lib/server/noded.py
@@ -216,7 +216,7 @@ class NodeHttpServer(http.server.HttpServer):
     """Remove a block device.

     """
-    devlist = [(objects.Disk.FromDict(ds), uid) for ds, uid in (params, )]
+    devlist = [(objects.Disk.FromDict(ds), uid) for ds, uid in params[0]]
     return backend.BlockdevRename(devlist)

   @staticmethod

Thanks for noticing this!
Michael