On Tue, Nov 15, 2011 at 10:47:46AM +0100, Michael Hanselmann wrote: > Am 15. November 2011 10:29 schrieb Iustin Pop <ius...@google.com>: > > On Tue, Nov 15, 2011 at 08:00:22AM +0100, Michael Hanselmann wrote: > >> --- a/lib/cmdlib.py > >> +++ b/lib/cmdlib.py > >> @@ -10258,6 +10281,9 @@ class TLReplaceDisks(Tasklet): > >> > >> self.cfg.Update(self.instance, feedback_fn) > >> > >> + # Release all node resource locks > >> + _ReleaseLocks(self.lu, locking.LEVEL_NODE) > > > > Either the comment or the code is wrong. I'd say the code, as the node > > locks were released earlier. > > The comment was indeed wrong (interdiff below), but I think the code > is correct. When replacing disks there are two cases. This is the one > for switching to a new secondary node. Once the configuration has been > updated and the disks created the node locks can be removed. There > will be lost disk space once the old disks have been removed.
Ah OK, LGTM then. thanks, iustin
