On Mon, Jan 9, 2012 at 11:58, Iustin Pop <ius...@google.com> wrote:
> This is a trivial conversion.
> ---
> autotools/convert-constants | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/autotools/convert-constants b/autotools/convert-constants
> index 89f9f00..ae36774 100755
> --- a/autotools/convert-constants
> +++ b/autotools/convert-constants
> @@ -27,8 +27,12 @@ import re
> from ganeti import constants
> from ganeti import compat
>
> +#: Constant name regex
> CONSTANT_RE = re.compile("^[A-Z][A-Z0-9_-]+$")
>
> +#: The type of regex objects
> +RE_TYPE = type(CONSTANT_RE)
> +
>
> def NameRules(name):
> """Converts the upper-cased Python name to Haskell camelCase.
> @@ -129,6 +133,12 @@ def ConvertVariable(name, value):
> lines.append("-- | Skipped list/set %s, is not homogeneous" % name)
> else:
> lines.append("-- | Skipped list/set %s, cannot convert all elems" %
> name)
> + elif isinstance(value, RE_TYPE):
> + tvs = HaskellTypeVal(value.pattern)
According to the doc, this is always a string. Any reason to anyway
going over HaskellTypeVal?
Rest LGTM
René
