On Wed, Mar 14, 2012 at 11:07, Iustin Pop <[email protected]> wrote: > On Mon, Mar 12, 2012 at 10:30:03AM +0100, Iustin Pop wrote: >> --- >> htools/offline-test.sh | 9 +++++++++ >> test/data/htools/common-suffix.data | 10 ++++++++++ >> test/data/htools/invalid-node.data | 10 ++++++++++ >> test/data/htools/missing-resources.data | 9 +++++++++ > > And again, test files not declared: > > diff --git a/Makefile.am b/Makefile.am > index b008d0d..1255da3 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -715,6 +715,9 @@ TEST_FILES = \ > test/data/htools/hail-change-group.json \ > test/data/htools/hail-node-evac.json \ > test/data/htools/hail-reloc-drbd.json \ > + test/data/htools/common-suffix.data \ > + test/data/htools/invalid-node.data \ > + test/data/htools/missing-resources.data \ > test/data/htools/rapi/groups.json \ > test/data/htools/rapi/info.json \ > test/data/htools/rapi/instances.json \
LGTM to me, including this :) René
