Hello. The patch is attached. I understand why I added a space, because the space has before %s " %s".
Best regards, Jack On Fri, Jun 29, 2012 at 12:24 PM, Jack Sitnikov <[email protected]> wrote: > Oh, I write a space because I didn't want any problem, but I don't know > about the problem with the parser. I make fix it and send new patch today. > > > On Fri, Jun 29, 2012 at 2:18 AM, Bernardo Dal Seno <[email protected]>wrote: > >> On Thu, Jun 28, 2012 at 11:21 PM, Jack Sitnikov <[email protected]> >> wrote: >> > I don't understand about a space in the line, and what is line? In xen >> config or code in the hv_xen module. >> >> In the format string "pci = %s \n" there is a space after the "%s" and >> before the newline "\n". It think it's useless if not harmful. >> >> Bernardo >> >> >> > 29.06.2012, в 0:57, Bernardo Dal Seno <[email protected]> написал(а): >> > >> >> On Thu, Jun 28, 2012 at 6:59 PM, Jack Sitnikov <[email protected]> >> wrote: >> >>> Thank you all. >> >>> Generate from git format-patch: >> >>> >> >>> From 7565c856efe5ddda635e4723724cc7118ac28151 Mon Sep 17 00:00:00 2001 >> >>> From: Jack <[email protected]> >> >>> Date: Thu, 28 Jun 2012 20:39:17 +0400 >> >>> Subject: [PATCH] Add PCI passthrough for hvm xen >> >> >> >> >> >>> + if pci_pass: >> >>> + pci_pass_arr = pci_pass.split(";") >> >>> + config.write("pci = %s \n" % pci_pass_arr) >> >> >> >> Is that a space before the newline? If it's not useful, it's better to >> >> avoid it, as it might create problems with parsing. >> >> >> >> Bernardo >> > > > > -- > С уважением, > Ситников Евгений > mailto:[email protected] > icq: 319044459 > tel. +7 (916)4215405 > -- С уважением, Ситников Евгений mailto:[email protected] icq: 319044459 tel. +7 (916)4215405
0001-Fix-small-bug-with-a-space-in-the-hv_xen-module-s-li.patch
Description: Binary data
