On Mon, Nov 19, 2012 at 03:19:51PM +0100, Michele Tartara wrote:
> A new directory for haskell modules about block devices has been created
> The parser is divided in two modules:
> * one exports the data types describing the DRBD status
> * one exports the parser itself
>
> Signed-off-by: Michele Tartara <mtart...@google.com>
One separate comment:
> +-- | Data type describing the DRBD version.
> +data VersionInfo =
> + VersionInfo
> + { version :: Maybe String -- ^ DRBD driver version
> + , api :: Maybe String -- ^ The api version
> + , proto :: Maybe String -- ^ The protocol version
> + , srcversion :: Maybe String -- ^ The version of the source files
> + , gitHash :: Maybe String -- ^ Git hash of the source files
> + , buildBy :: Maybe String -- ^ Who built the binary (and, optionally, when)
Should this be 'builtBy'?
thanks,
iustin
