LGTM, thanks
On Wed, Dec 12, 2012 at 11:28 AM, Iustin Pop <ius...@google.com> wrote: > This changes deps and comment fields to always be shown, to match the > Python behaviour for (at least) job listing/ops field. > > Signed-off-by: Iustin Pop <ius...@google.com> > --- > htools/Ganeti/OpParams.hs | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/htools/Ganeti/OpParams.hs b/htools/Ganeti/OpParams.hs > index f5f8c13..db16030 100644 > --- a/htools/Ganeti/OpParams.hs > +++ b/htools/Ganeti/OpParams.hs > @@ -1433,11 +1433,12 @@ pOpPriority = > > -- | Job dependencies. > pDependencies :: Field > -pDependencies = optionalField $ simpleField "depends" [t| [JobDependency] > |] > +pDependencies = > + optionalNullSerField $ simpleField "depends" [t| [JobDependency] |] > > -- | Comment field. > pComment :: Field > -pComment = optionalField $ stringField "comment" > +pComment = optionalNullSerField $ stringField "comment" > > -- * Entire opcode parameter list > > -- > 1.7.10.4 > >
