2013/1/21 Helga Velroyen <hel...@google.com>:
> I removed the "#default-nicparams", since it seems to be intended
> as an actual parameter to be used and not just a comment (since there is
> a sufficient comment above this line). So far the parameter was used in
> qa_cluster.py, line 119 and following:
> nicparams = qa_config.get("default-nicparams", None)
Yes, the default is to not set the NIC parameters on cluster
initialization and to use the built-in defaults (see commit 3601d488).
> This tries to retrieve 'default-nicparams', but fails, because the config
> says '#default-nicparams'. However, this bug was masked by the fact that
> the cluster QA falls back to some default. Since I intended to use it in
> the network QA, I fixed this here as well.
Sorry, I don't agree that this is a bug. Unless there are very good
reasons we should require changes to the QA configuration files and
instead have sensible defaults.
Michael
