2013/2/4 Iustin Pop <[email protected]>: > On Mon, Feb 04, 2013 at 01:17:08PM +0100, Michael Hanselmann wrote: >> 2013/2/4 Iustin Pop <[email protected]>: >> > --- a/lib/hypervisor/hv_base.py >> > +++ b/lib/hypervisor/hv_base.py >> > + @staticmethod >> > + def _FormatVerifyResults(msgs): >> >> Can you please make this a module-level function instead of a member >> of BaseHypervisor? > > I don't want to do that, as then the sub-modules would need to reference > hv_base's functions; I saw this approach (a class static function) as > simpler w.r.t. future changes.
Personally I don't like the proliferation of class-Level functions unless it's necessary for technical reasons (e.g. having to access instance or other class members). I don't think having to refer to “hv_base” for this idempotent function would be bad. Anyway, if you don't want there's nothing I can do except saying LGTM. Michael
