On 7 February 2013 09:17, Iustin Pop <[email protected]> wrote:
> On Wed, Feb 06, 2013 at 06:56:42PM +0100, Guido Trotter wrote:
>> Hi Iustin,
>>
>> Now that the rest of this patch series removes the wrong values from
>> the config, do you agree to have this change in as well?
>
> Personally I wouldn't do it, as I see this purely as a self-consistency
> check, and why would we remove such checks as long as the type system
> allows the config to become inconsistent?

I think I put this check in wrong place in the beginning, and that's
the problem. What if we move this check in ConfigWriter.VerifyConfig?
In this way it can be unit-tested and everybody is happy.

Bernardo

Reply via email to