On Mon, Feb 11, 2013 at 4:05 PM, Guido Trotter <[email protected]> wrote:
> From: Helga Velroyen <[email protected]> > > Until now if one disconnects a network with --no-conflicts-check > and then remove it, there is a possibility to leave instances with NICs > referencing non-existing networks. This causes network queries, > instance removal and modification to fail. > > This patch allows a network to be disconnected from a nodegroup, > only if instances residing in the nodegroup do not have NICs attached > to the network. Otherwise OpPrereqError is raised. The > --no-conflicts-check option is removed from the gnt-network disconnect > command as well. > > This is a cherry-pick of commit 6bb939a. > > Signed-off-by: Dimitris Aragiorgis <[email protected]> > Reviewed-by: Helga Velroyen <[email protected]> > --- > lib/client/gnt_network.py | 5 ++--- > lib/cmdlib.py | 10 ++++------ > lib/opcodes.py | 1 - > 3 files changed, 6 insertions(+), 10 deletions(-) > LGTM, thanks. Michele
