On Wed, Sep 5, 2012 at 12:36 PM, Iustin Pop <[email protected]> wrote: > On Mon, Sep 03, 2012 at 12:05:27PM +0100, Guido Trotter wrote: >> This is a long standing bug in Ganeti. Add a small design on how we plan >> to fix this for Ganeti 2.7. > >> +Masterd will know (through a constant map) which storage type uses which >> +method for storage calculation (i.e. ``plain`` and ``drbd`` use ``lvm``, >> +``file`` and ``sharedfile`` use ``filesystem``, etc) and query the one >> +needed (or all of the needed ones). >> + >> +Note that for file and sharedfile the node knows which directories are >> +allowed and won't allow any other directory to be queried for security >> +reasons. The actual path still needs to be passed to distinguish the >> +two, as the method will be the same for both. > > LGTM, except for the collapsing of file/sharedfile into filesystem. > While technically they are the same, I'm not 100% sure if we shouldn't > treat them the same at RPC level (even if on the backend it's the same > actual statfvs call). > > Anyway, LGTM, please commit, but what do you think about this? >
Hi Helga, Somehow I missed this and forgot to commit: since this was LGTMed, let me know if you want me to commit, and we can use it as a base for this task, if it helps. Thanks, Guido
