On Mon, Feb 18, 2013 at 04:20:01PM +0100, Michele Tartara wrote:
> In order to fetch precise information about the status of the VMs running in
> Xen, we need to analyze the output of the "xm list --long" command.
> 
> This commit adds the parser to do that, and its tests.

LGTM, one comment (my fault):

> +            (((:[]) <$> finalP) <|> (rparen >> pure [])))

The second alternative could be written, I think now, as: "rparen *> pure
[]". If that is true, and it passes the tests, please change it so, so
that we only use the Applicative form.

thanks!
iustin

Reply via email to